Added support for the Character Soulbinds API #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for the Character Soulbinds API. Added an ICharacterSoulbindsApi interface to describe the capabilities of the API. The IWarcraftClient interface implements this interface via the IProfileApi interface.
|
@willwolfram18, this change unfortunately introduces several types ( |
willwolfram18
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
No worries on the overlapping type references. I have to resolve some merge conflicts on the Resources.resx already 😅 I don't mind resolving some object types as well. I'm going to try get some tests in place to validate I've got all the attributes on the types i'm working with and then I'll work on getting the merges fixed in my branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Character Soulbinds API. Added an ICharacterSoulbindsApi interface to describe the capabilities of the API. The IWarcraftClient interface implements this interface via the IProfileApi interface. Resolves #162.